Re: Multiple -M options for git-cvsimport

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2008, 05:59 UTC
Message-ID: <7vejav7zns.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080229100241.GA6777@plop.home.bruhat.net>

"Philippe Bruhat (BooK)" <book@cpan.org> writes:

Show 9 quoted lines

> On Thu, Feb 28, 2008 at 12:07:46PM -0800, Junio C Hamano wrote:
>
>> I'll take a look at them later, when I have enough time to fish
>> for messages and discussions from earlier round in the list
>> archive in order to process this.
>
> You can ignore my previous messages, then. These four patches were
> rebased on the top of master, and correct the problems that were
> previously pointed to me.

I do not work that way.  I am a trust-but-verify kind of person.

So I dug up the old ones and the discussion. The series looks fine.

cvsimport: have default merge regex allow for dashes in the branch name

  You can extend the default with -M anyway, but I guess the
  default pattern can be loosened like this without increasing
  the risk of false hits, so probably it is Ok.

cvsimport: allow for multiple -M options

Ok.

cvsimport: document that -M can be used multiple times

  Ok, except that "can be used seveval times" should probably be
  "can be used more than once".

cvsimport: configure Getopt::Long to bundle options

  Ok.  Why isn't bundling the default, I have to wonder...