Re: Multiple -M options for git-cvsimport

From: Philippe Bruhat (BooK) <book@cpan.org>
Date: Feb 29, 2008, 10:02 UTC
Message-ID: <20080229100241.GA6777@plop.home.bruhat.net>
In-Reply-To: <7vzltkj14d.fsf@gitster.siamese.dyndns.org>

On Thu, Feb 28, 2008 at 12:07:46PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> "Philippe Bruhat (BooK)" <book@cpan.org> writes:
> 
> > Sending again my series of patches to git-cvsimport, which allow to
> > use several -M options for giving the regular expressions capturing the
> > source branch name when merging.
> 
> Could you be a bit more explicit than "Sending again", describe
> if it is just a straight resend, or what problems were pointed
> out in the earlier round (if any) and how they were addressed
> (or ignored, if any)?

Sorry.

In the previous round, an asciidoc formatting error was pointed in my doc patch, and you also noted that the t/t9600-cvsimport.sh test script failed after my Getopt::Std -> Getopt::Long patch.

I corrected all those problems (checked the asciidoc HTML output, and made sure the test script passed again).

> Also please Sign-off all your patches.  Cover letters do not
> need one.

It noticed that I forgot to -s my commits, so I thought that signing off the cover letter would be equivalent. I tried to follow the guidelines for sending patches, using format-patch and send-email, but I'm still a newbie both to git and it's development model.

> I'll take a look at them later, when I have enough time to fish
> for messages and discussions from earlier round in the list
> archive in order to process this.

You can ignore my previous messages, then. These four patches were rebased on the top of master, and correct the problems that were previously pointed to me.

    Thanks,

-- 
 Philippe Bruhat (BooK)

 The shortest distance between two points is not always the safest.
                                    (Moral from Groo The Wanderer #69 (Epic))