Re: Multiple -M options for git-cvsimport

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2008, 20:24 UTC
Message-ID: <7vbq5yyyyg.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vejav7zns.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 27 quoted lines

> "Philippe Bruhat (BooK)" <book@cpan.org> writes:
>
>> On Thu, Feb 28, 2008 at 12:07:46PM -0800, Junio C Hamano wrote:
>>
>>> I'll take a look at them later, when I have enough time to fish
>>> for messages and discussions from earlier round in the list
>>> archive in order to process this.
>>
>> You can ignore my previous messages, then. These four patches were
>> rebased on the top of master, and correct the problems that were
>> previously pointed to me.
>
> I do not work that way.  I am a trust-but-verify kind of person.
>
> So I dug up the old ones and the discussion.  The series looks
> fine.
> ...
> cvsimport: have default merge regex allow for dashes in the branch name
> ...
> cvsimport: allow for multiple -M options
>
>   Ok.
> ...
> cvsimport: document that -M can be used multiple times
> cvsimport: configure Getopt::Long to bundle options
>
>   Ok.  Why isn't bundling the default, I have to wonder...

I take these back.

The last one is an "Oops, the second one was an utter crap, it does not even pass the testsuite, well let's patch it up with an extra commit at the end."

Please don't do this. We do not have to record earlier mistakes in the public history.

I've squashed 4/4 into 2/4 and made it a 3-patch series.