git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: respect in-reply-to regardless of threading

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 3, 2009, 07:16 UTC
Message-ID
<7veixfgjpg.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<74fdbb84d14a6d39f1b61e18ab9588ca08926292.1235947339.git.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
Show 16 quoted lines
> git-send-email supports the --in-reply-to option even with
> --no-thread.  However, the code that adds the relevant mail headers
> was guarded by a test for --thread.
>
> Remove the test, so that the user's choice is respected.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> Thomas Rast wrote:
>> But it also turns out, as you can see, that git-send-email happily
>> ignores --in-reply-to if threading is disabled. :-(
>
> This is the minimally intrusive fix.  It would be more consistent to
> ask for the in-reply-to regardless of thread setting, but it would
> also be less of a fix and more of a behaviour change.
I agree.  Tests?
Previous: Thomas RastNext: Junio C Hamano
Message 4 of 6 in “fetch-pack: log(n)-transmission find_common()”
  1. 2/2 fetch-pack: log(n)-transmission find_common()Thomas Rast, Mar 1, 2009
  2. Thomas RastMar 1, 2009
  3. send-email: respect in-reply-to regardless of threadingThomas Rast, Mar 1, 2009
  4. Junio C HamanoMar 3, 2009
  5. Junio C HamanoMar 2, 2009
  6. 1/2 fetch-pack: rearrange main loopThomas Rast, Mar 1, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.