From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 Mar 2009 07:16:11 GMT
Subject: Re: [PATCH] send-email: respect in-reply-to regardless of threading
Message-ID: <7veixfgjpg.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <74fdbb84d14a6d39f1b61e18ab9588ca08926292.1235947339.git.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

> git-send-email supports the --in-reply-to option even with
> --no-thread.  However, the code that adds the relevant mail headers
> was guarded by a test for --thread.
>
> Remove the test, so that the user's choice is respected.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> Thomas Rast wrote:
>> But it also turns out, as you can see, that git-send-email happily
>> ignores --in-reply-to if threading is disabled. :-(
>
> This is the minimally intrusive fix.  It would be more consistent to
> ask for the in-reply-to regardless of thread setting, but it would
> also be less of a fix and more of a behaviour change.

I agree.  Tests?