[PATCH] send-email: respect in-reply-to regardless of threading

From: Thomas Rast <trast@student.ethz.ch>
Date: Mar 1, 2009, 22:45 UTC
Message-ID: <74fdbb84d14a6d39f1b61e18ab9588ca08926292.1235947339.git.trast@student.ethz.ch>
In-Reply-To: <200903012237.40891.trast@student.ethz.ch>

git-send-email supports the --in-reply-to option even with --no-thread. However, the code that adds the relevant mail headers was guarded by a test for --thread.

Remove the test, so that the user's choice is respected.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---

Thomas Rast wrote:

> But it also turns out, as you can see, that git-send-email happily
> ignores --in-reply-to if threading is disabled. :-(

This is the minimally intrusive fix. It would be more consistent to ask for the in-reply-to regardless of thread setting, but it would also be less of a fix and more of a behaviour change.

 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index adf7ecb..09fe3d9 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -821,7 +821,7 @@ sub get_patch_subject($) {
 Message-Id: $message_id
 X-Mailer: git-send-email $gitversion
 ";
-	if ($thread && $reply_to) {
+	if ($reply_to) {
 
 		$header .= "In-Reply-To: $reply_to\n";
 		$header .= "References: $references\n";

-- 
1.6.2.rc2.340.g83918