git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 0/7] i18n: mark missing C messages

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 12, 2011, 07:27 UTC
Message-ID
<7vei58q68f.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1302464048-21806-1-git-send-email-avarab@gmail.com>
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
Show 5 quoted lines
> This is an RFC because the first patch still leaves one remaining
> gitdir test failing under GETTEXT_POISON, and I won't be able to find
> out why tonight. Help welcome with figuring out why (in which case
> this should all be OK), you just need too build with
> GETTEXT_POISON=YesPlease and run t/t0001-init.sh.

I didn't even compile test this one, but I highly suspect that all the failures you saw come from the fact that .git file your patch produces with gettext poisoning (or any l10n) would be malformed and cannot be parsed by read_gitfile_gently() anymore.

I took a look at the remainder of the series, and except for the "do not call what you know is a singleton 'them'" grammo, everything looked fine to me.

I am tempted to merge them to 'master' before rc2; the alternative is to queue it on ab/i18n-fixup and keep it in 'next' until the 1.7.5 final, and have other people build on top of ab/i18n-fixup topic.

Previous: Junio C Hamano
Message 21 of 21 in “i18n: mark missing C messages”
  1. 0/7 i18n: mark missing C messagesÆvar Arnfjörð Bjarmason, Apr 10, 2011
  2. 1/7 i18n: mark init-db messages for translationÆvar Arnfjörð Bjarmason, Apr 10, 2011
  3. Junio C HamanoApr 12, 2011
  4. Junio C HamanoApr 12, 2011
  5. Ævar Arnfjörð BjarmasonApr 12, 2011
  6. Junio C HamanoApr 12, 2011
  7. Junio C HamanoApr 12, 2011
  8. Junio C HamanoApr 12, 2011
  9. i18n: use test_i18n{grep,cmp} in t7508Junio C Hamano, Apr 14, 2011
  10. 2/7 i18n: mark merge "Could not read from" message for translationÆvar Arnfjörð Bjarmason, Apr 10, 2011
  11. 3/7 i18n: mark merge "upstream" messages for translationÆvar Arnfjörð Bjarmason, Apr 10, 2011
  12. 4/7 i18n: mark merge CHERRY_PICK_HEAD messages for translationÆvar Arnfjörð Bjarmason, Apr 10, 2011
  13. 5/7 i18n: mark clone nonexistent repository message for translationÆvar Arnfjörð Bjarmason, Apr 10, 2011
  14. 6/7 i18n: mark checkout --detach messages for translationÆvar Arnfjörð Bjarmason, Apr 10, 2011
  15. 7/7 i18n: mark checkout plural warning for translationÆvar Arnfjörð Bjarmason, Apr 10, 2011
  16. Junio C HamanoApr 12, 2011
  17. Ævar Arnfjörð BjarmasonApr 12, 2011
  18. Junio C HamanoApr 12, 2011
  19. Ævar Arnfjörð BjarmasonApr 13, 2011
  20. Junio C HamanoApr 13, 2011
  21. Junio C HamanoApr 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.