git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: do not export mandir/htmldir/infodir

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 12, 2013, 23:09 UTC
Message-ID
<7vehgldt8e.fsf_-_@alter.siamese.dyndns.org>
In-Reply-To
<7vip5xdtt6.fsf@alter.siamese.dyndns.org>

These are defined in the main Makefile to be funny values that are optionally relative to an unspecified location that is determined at runtime. They are only suitable for hardcoding in the binary via the -DGIT_{MAN,HTML,INFO}_PATH=<value> C preprocessor options, and are not real paths, contrary to what any sane person, and more importantly, the Makefile in the documentation directory, would expect.

A longer term fix is to introduce runtime_{man,html,info}dir variables to hold these funny values, and make {man,html,info}dir variables to have real paths whose default values begin with $(prefix), but as a first step, stop exporting them from the top-level Makefile.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 1dae2c5..26b697d 100644
--- a/Makefile
+++ b/Makefile
@@ -359,7 +359,7 @@ lib = lib
 # DESTDIR=
 pathsep = :
 
-export prefix bindir sharedir mandir htmldir sysconfdir gitwebdir localedir
+export prefix bindir sharedir sysconfdir gitwebdir localedir
 
 CC = cc
 AR = ar
-- 
1.8.1.3.675.g524d3b9
Previous: Junio C HamanoNext: Jonathan Nieder
Message 15 of 20 in “Fix installation paths with "make install-doc"”
  1. 0/3 Fix installation paths with "make install-doc"John Keeping, Feb 12, 2013
  2. 1/3 Documentation/Makefile: fix spaces around assignmentsJohn Keeping, Feb 12, 2013
  3. Jonathan NiederFeb 12, 2013
  4. 2/3 Documentation/Makefile: move infodir to be with other '*dir'sJohn Keeping, Feb 12, 2013
  5. Jonathan NiederFeb 12, 2013
  6. John KeepingFeb 12, 2013
  7. 3/3 Documentation/Makefile: fix inherited {html,info,man}dirJohn Keeping, Feb 12, 2013
  8. Jonathan NiederFeb 12, 2013
  9. John KeepingFeb 12, 2013
  10. Jonathan NiederFeb 12, 2013
  11. Junio C HamanoFeb 12, 2013
  12. Junio C HamanoFeb 12, 2013
  13. John KeepingFeb 12, 2013
  14. Junio C HamanoFeb 12, 2013
  15. Makefile: do not export mandir/htmldir/infodirJunio C Hamano, Feb 12, 2013
  16. Jonathan NiederFeb 12, 2013
  17. John KeepingFeb 12, 2013
  18. Makefile: make mandir, htmldir and infodir absoluteJohn Keeping, Feb 24, 2013
  19. Junio C HamanoFeb 25, 2013
  20. John KeepingFeb 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.