git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Fix installation paths with "make install-doc"

From
John Keeping <john@keeping.me.uk>
Date
Feb 12, 2013, 23:06 UTC
Message-ID
<20130212230600.GB22779@river>
In-Reply-To
<7vip5xdtt6.fsf@alter.siamese.dyndns.org>
On Tue, Feb 12, 2013 at 02:57:25PM -0800, Junio C Hamano wrote:
Show 34 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > I _think_ exporting mandir/html/infodir from the top-level Makefile
> > is wrong to begin with.  We should drop the "export mandir" from
> > there.
> 
> Ah, it is this thing, isn't it?
> 
> commit d8cf908cb6012cd4dc3d1089a849daf646150c2e
> Author: Junio C Hamano <gitster@pobox.com>
> Date:   Sat Feb 2 17:58:49 2013 -0800
> 
>     config.mak.in: remove unused definitions
>     
>     When 5566771 (autoconf: Use autoconf to write installation
>     directories to config.mak.autogen, 2006-07-03) introduced support
>     for autoconf generated config.mak file, it added an "export" for a
>     few common makefile variables, in addition to definitions of srcdir
>     and VPATH.
>     
>     The "export" logically does not belong there.  The make variables
>     like mandir, prefix, etc, should be exported to submakes for people
>     who use config.mak and people who use config.mak.autogen the same
>     way; if we want to get these exported, that should be in the main
>     Makefile.
>     
>     We do use mandir and htmldir in Documentation/Makefile, so let's
>     add export for them in the main Makefile instead.
>     
>     We may eventually want to support VPATH, and srcdir may turn out to
>     be useful for that purpose, but right now nobody uses it, so it is
>     useless to define them in this file.
>     
>     Signed-off-by: Junio C Hamano <gitster@pobox.com>

Looks like it - I tried this for the first time today (with pu) so I didn't realise it was a recent change, and I didn't think to blame the export line.

John
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 20 in “Fix installation paths with "make install-doc"”
  1. 0/3 Fix installation paths with "make install-doc"John Keeping, Feb 12, 2013
  2. 1/3 Documentation/Makefile: fix spaces around assignmentsJohn Keeping, Feb 12, 2013
  3. Jonathan NiederFeb 12, 2013
  4. 2/3 Documentation/Makefile: move infodir to be with other '*dir'sJohn Keeping, Feb 12, 2013
  5. Jonathan NiederFeb 12, 2013
  6. John KeepingFeb 12, 2013
  7. 3/3 Documentation/Makefile: fix inherited {html,info,man}dirJohn Keeping, Feb 12, 2013
  8. Jonathan NiederFeb 12, 2013
  9. John KeepingFeb 12, 2013
  10. Jonathan NiederFeb 12, 2013
  11. Junio C HamanoFeb 12, 2013
  12. Junio C HamanoFeb 12, 2013
  13. John KeepingFeb 12, 2013
  14. Junio C HamanoFeb 12, 2013
  15. Makefile: do not export mandir/htmldir/infodirJunio C Hamano, Feb 12, 2013
  16. Jonathan NiederFeb 12, 2013
  17. John KeepingFeb 12, 2013
  18. Makefile: make mandir, htmldir and infodir absoluteJohn Keeping, Feb 24, 2013
  19. Junio C HamanoFeb 25, 2013
  20. John KeepingFeb 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.