git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Add "next" link to commitdiff view

From
Junio C Hamano <junkio@cox.net>
Date
Oct 22, 2006, 23:16 UTC
Message-ID
<7vd58k0wmx.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<200610230037.57183.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 15 quoted lines
> Add a kind of "next" view in the bottom part of navigation bar for
> "commitdiff" view.
>
> For commitdiff between two commits:
>   (from: _commit_)
> For commitdiff for one single parent commit:
>   (parent: _commit_)
> For commitdiff for one merge commit
>   (merge: _commit_ _commit_ ...)
> For commitdiff for root (parentless) commit
>   (initial)
> where _link_ denotes hyperlink. SHA1 is shortened to 7 characters on
> display, everything is perhaps unnecessary esc_html on display.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>

Would it even be necessary to use any SHA-1 name in these cases, I wonder. Would it make the page less useful if we replace all of the above _commit_ with a fixed string, say, "parent"?

I always hated gitweb diffs that prefix each filepair with their full 40-byte SHA-1 blob object names. It just adds noise to the output without adding any meaningful information.

Previous: Jakub NarebskiNext: Jakub Narebski
Message 3 of 16 in “gitweb: Add "next" link to commitdiff view”
  1. gitweb: Add "next" link to commitdiff viewJakub Narebski, Oct 22, 2006
  2. Jakub NarebskiOct 22, 2006
  3. Junio C HamanoOct 22, 2006
  4. Jakub NarebskiOct 22, 2006
  5. 2/1 gitweb: Use fixed string for "next" link in commitdiff viewJakub Narebski, Oct 23, 2006
  6. Petr BaudisOct 23, 2006
  7. 2/1 gitweb: Use fixed string for "next" link in commitdiff viewJakub Narebski, Oct 24, 2006
  8. Junio C HamanoOct 24, 2006
  9. Jakub NarebskiOct 24, 2006
  10. Petr BaudisOct 24, 2006
  11. Jakub NarebskiOct 24, 2006
  12. Petr BaudisOct 24, 2006
  13. Junio C HamanoOct 24, 2006
  14. Petr BaudisOct 24, 2006
  15. Junio C HamanoOct 24, 2006
  16. Jakub NarebskiOct 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.