Re: [PATCH 2/1 (amend)] gitweb: Use fixed string for "next" link in commitdiff view
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Oct 24, 2006, 09:28 UTC
- Message-ID
- <200610241128.34532.jnareb@gmail.com>
- In-Reply-To
- <7vfydehy2q.fsf@assigned-by-dhcp.cox.net>
Dnia wtorek 24. października 2006 11:17, Junio C Hamano napisał:
Show 12 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes: > >> Use fixed string instead of shortened SHA1 identifier of commit >> as a name for "mext" link in commitdiff view. >> >> While at it make sure that we don't mistake option for a second >> commit. >> >> Signed-off-by: Jakub Narebski <jnareb@gmail.com> >> --- > > Q1. (amend) to fix what?
Petr "Pasky" Baudis wrote:
Show 5 quoted lines
>> } else {
>> # merge commit
>> $formats_nav .=
>> - ' (merge: ' .
>> + ' (' .[...]
> For people not used to git, it would be more informative to keep the > 'merge' text there.
It also fixes detection if it is diff of two specified commits. Although $hash_parent is set to '--root' for rootloess commit later, we could have it set by hand. This is also preparation for later using '--cc' (although we wouldn't generate such URL, I don't think).
> Q2. "mext"?
Oops.
-- Jakub Narebski Poland