git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/1] gitweb: Use fixed string for "next" link in commitdiff view

From
Petr Baudis <pasky@suse.cz>
Date
Oct 24, 2006, 11:49 UTC
Message-ID
<20061024114923.GD20017@pasky.or.cz>
In-Reply-To
<200610240008.08325.jnareb@gmail.com>

Dear diary, on Tue, Oct 24, 2006 at 12:08:08AM CEST, I got a letter where Jakub Narebski <jnareb@gmail.com> said that...

> Use fixed string instead of shortened SHA1 identifier of commit
> as a name for "mext" link in commitdiff view.
> 
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>

So I've read what the patch actually does this time, and I really dislike it.

Show 20 quoted lines
> Junio C Hamano wrote:
> > Jakub Narebski <jnareb@gmail.com> writes:
> > 
> >> Add a kind of "next" link in the bottom part of navigation bar for
> >> "commitdiff" view.
> >>
> >> For commitdiff between two commits:
> >>   (from: _commit_)
> >> For commitdiff for one single parent commit:
> >>   (parent: _commit_)
> >> For commitdiff for one merge commit
> >>   (merge: _commit_ _commit_ ...)
> >> For commitdiff for root (parentless) commit
> >>   (initial)
> >> where _link_ denotes hyperlink. SHA1 is shortened to 7 characters on
> >> display, everything is perhaps unnecessary esc_html on display.
> > 
> > I always hated gitweb diffs that prefix each filepair with their
> > full 40-byte SHA-1 blob object names.  It just adds noise to the
> > output without adding any meaningful information.

I agree, using the shortened SHA1 would be definitely an improvement here, but

> > Would it even be necessary to use any SHA-1 name in these cases,
> > I wonder.  Would it make the page less useful if we replace all
> > of the above _commit_ with a fixed string, say, "parent"?

I really disagree here - what's the point of not using SHA-1? The extra string carries zero information in comparison with the previous state and I just can't see how it *improves* stuff. If you're walking in a maze and making marks on walls, it's still more useful if you have corridors named by "A", "B", "C", "D" on junctions if you sometimes want to walk back to the marked corridors.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
Previous: Jakub NarebskiNext: Jakub Narebski
Message 10 of 16 in “gitweb: Add "next" link to commitdiff view”
  1. gitweb: Add "next" link to commitdiff viewJakub Narebski, Oct 22, 2006
  2. Jakub NarebskiOct 22, 2006
  3. Junio C HamanoOct 22, 2006
  4. Jakub NarebskiOct 22, 2006
  5. 2/1 gitweb: Use fixed string for "next" link in commitdiff viewJakub Narebski, Oct 23, 2006
  6. Petr BaudisOct 23, 2006
  7. 2/1 gitweb: Use fixed string for "next" link in commitdiff viewJakub Narebski, Oct 24, 2006
  8. Junio C HamanoOct 24, 2006
  9. Jakub NarebskiOct 24, 2006
  10. Petr BaudisOct 24, 2006
  11. Jakub NarebskiOct 24, 2006
  12. Petr BaudisOct 24, 2006
  13. Junio C HamanoOct 24, 2006
  14. Petr BaudisOct 24, 2006
  15. Junio C HamanoOct 24, 2006
  16. Jakub NarebskiOct 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.