git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add support for commit.signoff config option

From
Junio C Hamano <junkio@cox.net>
Date
Nov 28, 2006, 20:17 UTC
Message-ID
<7vd5772unw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<200611281202.43394.andyparkins@gmail.com>
Andy Parkins <andyparkins@gmail.com> writes:
Show 6 quoted lines
> Whether patches require signing off or not is probably a per-project
> setting rather than a per-commit setting.  Therefore as a convenience to
> the user, the commit.signoff setting will automtically add --signoff to
> commits.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>

I muttered something about commit templates which would make this change a moot point, but independent of that...

Show 6 quoted lines
> +# Config
> +case "$(git-repo-config --get commit.signoff)" in
> +1|on|yes|true)
> +	signoff=t
> +	;;
> +esac
this is ugly; please use --bool and check only for 'true'.
Previous: Andy ParkinsNext: Andy Parkins
Message 2 of 4 in “Add support for commit.signoff config option”
  1. Add support for commit.signoff config optionAndy Parkins, Nov 28, 2006
  2. Junio C HamanoNov 28, 2006
  3. Add --bool and --int to the OPTIONS sectionAndy Parkins, Nov 29, 2006
  4. Johannes SchindelinNov 29, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.