From: Junio C Hamano <junkio@cox.net>
Date: Tue, 28 Nov 2006 20:17:07 GMT
Subject: Re: [PATCH] Add support for commit.signoff config option
Message-ID: <7vd5772unw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200611281202.43394.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

> Whether patches require signing off or not is probably a per-project
> setting rather than a per-commit setting.  Therefore as a convenience to
> the user, the commit.signoff setting will automtically add --signoff to
> commits.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>

I muttered something about commit templates which would make
this change a moot point, but independent of that...

> +# Config
> +case "$(git-repo-config --get commit.signoff)" in
> +1|on|yes|true)
> +	signoff=t
> +	;;
> +esac

this is ugly; please use --bool and check only for 'true'.