Re: [PATCH] Add --bool and --int to the OPTIONS section

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 29, 2006, 10:09 UTC
Message-ID: <Pine.LNX.4.63.0611291107130.30004@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <200611290825.40953.andyparkins@gmail.com>

Hi,

On Wed, 29 Nov 2006, Andy Parkins wrote:

> Signed-off-by: Andy Parkins <andyparkins@gmail.com>
> ---

You might want to use a more-to-the-point subject, and move this into the commit message:

> I did look for just such an option, but didn't find it because it wasn't 
> in the OPTIONS list of the git-repo-config man page.  If there is an 
> OPTIONS section it should include all options, otherwise it's no use as 
> a quick reference.

And this belongs into another mail:

> Your template commit message is an excellent idea, but I don't like the idea 
> of simply hard coding sign off line into it; it means that there are then two 
> locations in the .git tree that I'd have to edit to change my name. 
> [...]

But to answer your concern: you would do this as a hook, which is a script in which you do not put your name directly. Rather, this script gets the current author name by calling either git-var or git-repo-config.

Ciao, Dscho