git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 31, 2007, 22:12 UTC
Message-ID
<7vd4y8fcjw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<11858807944170-git-send-email-jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 10 quoted lines
> It allows to play with 'tree' view with blob size. Currently you
> have to start browsing by adding ";opt=-l" to the gitweb URL by
> hand.  There is not link which will change view from ordinary 'tree'
> view to 'tree' view with blob sizes.
>
> The 'tree' with blob size view is slightly more costly than the
> ordinary, old 'tree' view, but not much more (0.018s vs 0.012s
> in the hot cache case), so I don't think we need to control it
> as a enabled (or disabled) feature, overrideable or not.  It
> probably should not be default.

I do not think there is any reason to forbid its use, as the "-l" to ls-tree was introduced for exactly this purpose, However, it might make sense to make the use of -l optional via the %feature mechanism. 50% increase even on hot cache case is not a price people who run busy sites would want to pay.

Previous: Jakub NarebskiNext: Jakub Narebski
Message 3 of 11 in “gitweb: Allow for multivalued parameters passed to href subroutine”
  1. 1/2 gitweb: Allow for multivalued parameters passed to href subroutineJakub Narebski, Jul 31, 2007
  2. 2/2 gitweb: Add an option to show size of blobs in the tree viewJakub Narebski, Jul 31, 2007
  3. Junio C HamanoJul 31, 2007
  4. Jakub NarebskiAug 1, 2007
  5. Junio C HamanoAug 1, 2007
  6. Jakub NarebskiAug 1, 2007
  7. Junio C HamanoAug 2, 2007
  8. Junio C HamanoAug 2, 2007
  9. Jakub NarebskiAug 2, 2007
  10. Junio C HamanoAug 2, 2007
  11. Jakub NarebskiJul 31, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.