[PATCH 1/2] gitweb: Allow for multivalued parameters passed to href subroutine
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jul 31, 2007, 11:19 UTC
- Message-ID
- <1185880790812-git-send-email-jnareb@gmail.com>
Make it possible to generate URLs with multivalued parameters in the href() subroutine, via passing reference to array of values.
Example: href(action=>"log", extra_options=>["--no-merges", "--first-parent"])
This also allows for easy passing back (replaying) current value of, possibly multivalued, extra_options ('opt') parameter, using:
href(..., extra_options=>\@extra_options)
which would be required when we start using extra_options in gitweb, and would want to preserve its value. For example when creating links to next/previous page of 'log' or 'history' view output, we would want to preserve '--no-merges' and/or '-first-parent' extra options.
Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- This is the same patch as sent earlier, but with more detailed commit message. As the previous version made it into git.git, this is just for archives.
gitweb/gitweb.perl | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 8a32899..498b936 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -629,7 +629,13 @@ sub href(%) { for (my $i = 0; $i < @mapping; $i += 2) { my ($name, $symbol) = ($mapping[$i], $mapping[$i+1]); if (defined $params{$name}) { - push @result, $symbol . "=" . esc_param($params{$name}); + if (ref($params{$name}) eq "ARRAY") { + foreach my $par (@{$params{$name}}) { + push @result, $symbol . "=" . esc_param($par); + } + } else { + push @result, $symbol . "=" . esc_param($params{$name}); + } } } $href .= "?" . join(';', @result) if scalar @result;
-- 1.5.2.4