git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] git-tag -s must fail if gpg is broken and cannot sign tags

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 6, 2007, 06:20 UTC
Message-ID
<7vd4wwe2n5.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20070906042653.GQ18160@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 14 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> wrote:
>> If the user has misconfigured `user.signingkey` in their .git/config
>> or just doesn't have any secret keys on their keyring and they ask
>> for a signed tag with `git tag -s` we better make sure the resulting
>> tag was actually signed by gpg.
> ...
>>  I think this and my prior contrib/workdir patch should both go into
>>  maint.  This one in particular; it hurt us today when an automated
>>  tool that runs `git tag -s` didn't notice the GnuPG problems.
>
> I'm sorry, despite the subject of this email this is actually a
> *one* patch series.  The 2/2 is because I applied and tested this
> on top of the contrib/workdir patch I was talking about above and
> my email sending script thought it was a two patch series.

This seems to fail the test depending on the order processes happen to be scheduled. I haven't looked at it closely yet.

Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 3 of 5 in “git-tag -s must fail if gpg is broken and cannot sign tags”
  1. 2/2 git-tag -s must fail if gpg is broken and cannot sign tagsShawn O. Pearce, Sep 6, 2007
  2. Shawn O. PearceSep 6, 2007
  3. Junio C HamanoSep 6, 2007
  4. Shawn O. PearceSep 7, 2007
  5. Carlos RicaSep 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.