From: Junio C Hamano Date: Thu, 06 Sep 2007 06:20:14 GMT Subject: Re: [PATCH 2/2] git-tag -s must fail if gpg is broken and cannot sign tags Message-ID: <7vd4wwe2n5.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20070906042653.GQ18160@spearce.org> "Shawn O. Pearce" writes: > "Shawn O. Pearce" wrote: >> If the user has misconfigured `user.signingkey` in their .git/config >> or just doesn't have any secret keys on their keyring and they ask >> for a signed tag with `git tag -s` we better make sure the resulting >> tag was actually signed by gpg. > ... >> I think this and my prior contrib/workdir patch should both go into >> maint. This one in particular; it hurt us today when an automated >> tool that runs `git tag -s` didn't notice the GnuPG problems. > > I'm sorry, despite the subject of this email this is actually a > *one* patch series. The 2/2 is because I applied and tested this > on top of the contrib/workdir patch I was talking about above and > my email sending script thought it was a two patch series. This seems to fail the test depending on the order processes happen to be scheduled. I haven't looked at it closely yet.