Re: [PATCH 2/2] git-tag -s must fail if gpg is broken and cannot sign tags

From: Shawn O. Pearce <spearce@spearce.org>
Date: Sep 7, 2007, 04:58 UTC
Message-ID: <20070907045833.GZ18160@spearce.org>
In-Reply-To: <7vd4wwe2n5.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > "Shawn O. Pearce" <spearce@spearce.org> wrote:
> >> If the user has misconfigured `user.signingkey` in their .git/config
> >> or just doesn't have any secret keys on their keyring and they ask
> >> for a signed tag with `git tag -s` we better make sure the resulting
> >> tag was actually signed by gpg.
> 
> This seems to fail the test depending on the order processes
> happen to be scheduled.  I haven't looked at it closely yet.

That's not good. I noticed stepping through the code last night that if gpg is misconfigured (e.g. set a bad user.signingkey in .git/config) it will terminate and send SIGPIPE to git-tag, which makes it terminate.

All my change did was implement proper error handling. So if you are seeing failures now then we probably have a problem with the code without my patch too...

-- 
Shawn.