git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] "color.diff = true" is not "always" anymore.

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 1, 2007, 06:10 UTC
Message-ID
<7vd4tr6j38.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20071201041549.GB30725@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> On Fri, Nov 30, 2007 at 06:36:44PM -0800, Junio C Hamano wrote:
>
>> > It would be nice to have a "git config --colorbool" option, but it has
>> > the unfortunate problem that the stdout of "git config" is piped back to
>> > the caller, so the isatty check is meaningless (and the "pager in use"
>> > is similarly tricky). Perhaps it should go in Git.pm, so it at least
>> > only needs to be written once.
>> 
>> About the isatty(3) check, you do not have to use the stdout to report
>> the result, though.  IOW, you could use the exit code from the command.
>
> I thought about that, but it feels a little wrong since it is so unlike
> all of the other interfaces to git-config.

Yeah, that is why I did not seriously suggest it. The message you were responding to was sitting in my "I do not know if this should go out" box for a few days and was sent out purely by accident ;-)

Previous: Jeff King
Message 10 of 10 in “Use --no-color option on git log commands.”
  1. Use --no-color option on git log commands.Pascal Obry, Nov 26, 2007
  2. Junio C HamanoNov 26, 2007
  3. Pascal ObryNov 27, 2007
  4. Junio C HamanoNov 28, 2007
  5. "color.diff = true" is not "always" anymore.Junio C Hamano, Nov 28, 2007
  6. Johannes SchindelinNov 28, 2007
  7. Jeff KingNov 28, 2007
  8. Junio C HamanoDec 1, 2007
  9. Jeff KingDec 1, 2007
  10. Junio C HamanoDec 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.