Re: [PATCH/RFC] "color.diff = true" is not "always" anymore.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 1, 2007, 02:36 UTC
- Message-ID
- <7v4pf39m4j.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20071128190439.GA11396@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> It would be nice to have a "git config --colorbool" option, but it has > the unfortunate problem that the stdout of "git config" is piped back to > the caller, so the isatty check is meaningless (and the "pager in use" > is similarly tricky). Perhaps it should go in Git.pm, so it at least > only needs to be written once.
About the isatty(3) check, you do not have to use the stdout to report the result, though. IOW, you could use the exit code from the command.