From: Junio C Hamano Date: Sat, 01 Dec 2007 06:10:35 GMT Subject: Re: [PATCH/RFC] "color.diff = true" is not "always" anymore. Message-ID: <7vd4tr6j38.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20071201041549.GB30725@coredump.intra.peff.net> Jeff King writes: > On Fri, Nov 30, 2007 at 06:36:44PM -0800, Junio C Hamano wrote: > >> > It would be nice to have a "git config --colorbool" option, but it has >> > the unfortunate problem that the stdout of "git config" is piped back to >> > the caller, so the isatty check is meaningless (and the "pager in use" >> > is similarly tricky). Perhaps it should go in Git.pm, so it at least >> > only needs to be written once. >> >> About the isatty(3) check, you do not have to use the stdout to report >> the result, though. IOW, you could use the exit code from the command. > > I thought about that, but it feels a little wrong since it is so unlike > all of the other interfaces to git-config. Yeah, that is why I did not seriously suggest it. The message you were responding to was sitting in my "I do not know if this should go out" box for a few days and was sent out purely by accident ;-)