From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 05 Feb 2008 23:43:43 GMT
Subject: Re: [PATCH 1/9] Allow callers of unpack_trees() to handle failure
Message-ID: <7vd4rb7yvk.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LNX.1.00.0802051428180.13593@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

> On Tue, 5 Feb 2008, Johannes Schindelin wrote:
> ...
>> BTW after the whole series (was too lazy to check the individual 
>> patches), I count one instance in builtin-checkout.c and two in diff-lib.c 
>> where unpack_trees()' return value is not checked.  Is this intended?
>
> ..., but it's probably best to check and 
> exit anyway, if only in the conversion commit. (If we remove the check 
> afterward, there will be a change in the history that documents that we 
> don't need to check)

I think that is a sensible thing to do.