git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] perl/Git.pm: add parse_rev method

From
Junio C Hamano <gitster@pobox.com>
Date
May 30, 2008, 21:25 UTC
Message-ID
<7vd4n3iivt.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080530210531.GH18781@machine.or.cz>
Petr Baudis <pasky@suse.cz> writes:
Show 7 quoted lines
> On Fri, May 30, 2008 at 10:27:50PM +0200, Lea Wiemann wrote:
>> The parse_rev method takes a revision name and returns a SHA1 hash,
>> like the git-rev-parse command.
>> 
>> Signed-off-by: Lea Wiemann <LeWiemann@gmail.com>
>
> Nice, this looks quite sane!

Perhaps, but except for the use of nonstandard try...catch. I have been wondering if we can move away from it, with the goal of eventually getting rid of the construct altogether.

Didn't we hear from Randal that the construct is known to be leaky?
Previous: Petr BaudisNext: Randal L. Schwartz
Message 13 of 32 in “perl/Git.pm: add rev_parse method”
  1. perl/Git.pm: add rev_parse methodLea Wiemann, May 30, 2008
  2. Lea WiemannMay 30, 2008
  3. Petr BaudisMay 30, 2008
  4. Merging strategy for extending Git.pm (was: [PATCH] perl/Git.pm: add rev_parse method)Lea Wiemann, May 30, 2008
  5. Junio C HamanoMay 30, 2008
  6. Johannes SchindelinMay 31, 2008
  7. Lea WiemannMay 31, 2008
  8. Johannes SchindelinMay 31, 2008
  9. Junio C HamanoMay 30, 2008
  10. Petr BaudisMay 30, 2008
  11. perl/Git.pm: add parse_rev methodLea Wiemann, May 30, 2008
  12. Petr BaudisMay 30, 2008
  13. Junio C HamanoMay 30, 2008
  14. Randal L. SchwartzMay 30, 2008
  15. Lea WiemannMay 30, 2008
  16. Randal L. SchwartzMay 30, 2008
  17. Lea WiemannMay 30, 2008
  18. Junio C HamanoMay 30, 2008
  19. Johannes SchindelinMay 31, 2008
  20. Support for old Perl versionsPetr Baudis, May 31, 2008
  21. Johannes SchindelinMay 31, 2008
  22. Petr BaudisMay 30, 2008
  23. perl/Git.pm: add parse_rev methodLea Wiemann, May 31, 2008
  24. perl/Git.pm: add parse_rev methodLea Wiemann, Jun 1, 2008
  25. perl/Git.pm: add parse_rev methodLea Wiemann, Jun 1, 2008
  26. Lea WiemannJun 1, 2008
  27. Miklos VajnaJun 1, 2008
  28. Lea WiemannJun 1, 2008
  29. Junio C HamanoJun 2, 2008
  30. Lea WiemannJun 2, 2008
  31. perl/Git.pm: add get_hash methodLea Wiemann, Jun 1, 2008
  32. perl/Git.pm: add get_hash methodLea Wiemann, Jun 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.