From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 30 May 2008 21:25:58 GMT
Subject: Re: [PATCH] perl/Git.pm: add parse_rev method
Message-ID: <7vd4n3iivt.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080530210531.GH18781@machine.or.cz>

Petr Baudis <pasky@suse.cz> writes:

> On Fri, May 30, 2008 at 10:27:50PM +0200, Lea Wiemann wrote:
>> The parse_rev method takes a revision name and returns a SHA1 hash,
>> like the git-rev-parse command.
>> 
>> Signed-off-by: Lea Wiemann <LeWiemann@gmail.com>
>
> Nice, this looks quite sane!

Perhaps, but except for the use of nonstandard try...catch.  I have been
wondering if we can move away from it, with the goal of eventually getting
rid of the construct altogether.

Didn't we hear from Randal that the construct is known to be leaky?