git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] perl/Git.pm: add rev_parse method

From
LWLea Wiemann <lewiemann@gmail.com>
Date
May 30, 2008, 04:43 UTC
Message-ID
<1212122585-7350-1-git-send-email-LeWiemann@gmail.com>

The rev_parse method translates a revision name to a SHA1 hash, like the git-rev-parse command.

Signed-off-by: Lea Wiemann <LeWiemann@gmail.com>
---

This is part of my work to extend Git.pm to create a usable repository access abstraction layer for gitweb.

I've tested this method by calling it with a few parameters, but there's no test suite yet. I'll probably send a message to the mailing list about testing Git.pm soon.

This is my first patch to Git.pm, so please let me know if there is anything wrong with it!

 perl/Git.pm |   22 ++++++++++++++++++++++
 1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index d05b633..9ef8cb0 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -716,6 +716,28 @@ sub ident_person {
 	return "$ident[0] <$ident[1]>";
 }
 
+=item rev_parse ( REVISION_NAME )
+
+Look up the specified revision name and return the SHA1 hash, or
+return undef if the lookup failed.  See the git-rev-parse command.
+
+=cut
+
+sub rev_parse {
+    # We could allow for a list of revisions here.
+    my ($self, $rev_name) = @_;
+
+    my $hash;
+    try {
+        # The --default option works around rev-parse's lack of
+        # support for getopt style "--" separators (it would fail for
+        # tags named "--foo" without it).
+        $hash = $self->command_oneline("rev-parse", "--verify", "--default",
+                                       $rev_name);
+    } catch Git::Error::Command with { };
+    return undef unless defined $hash and $hash =~ /^([0-9a-fA-F]{40})$/;
+    $hash;
+}
 
 =item hash_object ( TYPE, FILENAME )
 
-- 
1.5.5.GIT
Next: Lea Wiemann
Message 1 of 32 in “perl/Git.pm: add rev_parse method”
  1. perl/Git.pm: add rev_parse methodLea Wiemann, May 30, 2008
  2. Lea WiemannMay 30, 2008
  3. Petr BaudisMay 30, 2008
  4. Merging strategy for extending Git.pm (was: [PATCH] perl/Git.pm: add rev_parse method)Lea Wiemann, May 30, 2008
  5. Junio C HamanoMay 30, 2008
  6. Johannes SchindelinMay 31, 2008
  7. Lea WiemannMay 31, 2008
  8. Johannes SchindelinMay 31, 2008
  9. Junio C HamanoMay 30, 2008
  10. Petr BaudisMay 30, 2008
  11. perl/Git.pm: add parse_rev methodLea Wiemann, May 30, 2008
  12. Petr BaudisMay 30, 2008
  13. Junio C HamanoMay 30, 2008
  14. Randal L. SchwartzMay 30, 2008
  15. Lea WiemannMay 30, 2008
  16. Randal L. SchwartzMay 30, 2008
  17. Lea WiemannMay 30, 2008
  18. Junio C HamanoMay 30, 2008
  19. Johannes SchindelinMay 31, 2008
  20. Support for old Perl versionsPetr Baudis, May 31, 2008
  21. Johannes SchindelinMay 31, 2008
  22. Petr BaudisMay 30, 2008
  23. perl/Git.pm: add parse_rev methodLea Wiemann, May 31, 2008
  24. perl/Git.pm: add parse_rev methodLea Wiemann, Jun 1, 2008
  25. perl/Git.pm: add parse_rev methodLea Wiemann, Jun 1, 2008
  26. Lea WiemannJun 1, 2008
  27. Miklos VajnaJun 1, 2008
  28. Lea WiemannJun 1, 2008
  29. Junio C HamanoJun 2, 2008
  30. Lea WiemannJun 2, 2008
  31. perl/Git.pm: add get_hash methodLea Wiemann, Jun 1, 2008
  32. perl/Git.pm: add get_hash methodLea Wiemann, Jun 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.