Re: [PATCH] Allow --quiet option to git remote, particularly for `git remote update`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 6, 2009, 02:04 UTC
- Message-ID
- <7vd42soo2p.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1260057623-28960-1-git-send-email-alex@chmrr.net>
Alex Vandiver <alex@chmrr.net> writes:
> Signed-off-by: Alex Vandiver <alex@chmrr.net>
Sounds good as it makes the behaviour consistent with the underlying "git fetch".
> ... > "git remote prune [-n | --dry-run] <name>", > - "git remote [-v | --verbose] update [-p | --prune] [group | remote]", > + "git remote [-v | --verbose] [-q | --quiet] update [-p | --prune] [group]",
We say "<name>" everywhere else except for "update" we call the parameter "group" or "remote" using different typography. It is not the fault of your patch, but has been this way since 1918278 (Allow git-remote to update named groups of remotes, 2007-02-20).
Three issues to consider:
- shouldn't we use the same typography, i.e. <group>?
- should we say <name> _if_ we are not going to say <group>|<remote>?
- should we keep it as <group>|<remote> to make it clear that only this subcommand allows the group nickname?
The first two are easy and I expect the answers to be both yes. The third one needs some studying and further thought.
- is "remote update" the only one that takes group nickname?
- should "remote update" the only one? e.g. does "remote prune" also take group? if not, shouldn't it?