Re: [PATCH] Allow --quiet option to git remote, particularly for `git remote update`

From: Jeff King <peff@peff.net>
Date: Dec 7, 2009, 06:40 UTC
Message-ID: <20091207064007.GA3664@coredump.intra.peff.net>
In-Reply-To: <1260156352-sup-6170@utwig>

On Mon, Dec 07, 2009 at 01:15:05AM -0500, Alex Vandiver wrote:

Show 9 quoted lines

> At Sun Dec 06 09:50:00 -0500 2009, Jeff King wrote:
> > Should --quiet also affect this "Updating %s" line?
> 
> Looking at it more closely, I think this patch should -- but for
> reasons unrelated o your argument below.  The "Updating %s" line there
> is in fetch_remote, which is _only_ called during `git remote add -f`.
> It stands in for the "Fetching %s" line which `git fetch` (and `git
> remote update`) outputs, which (after this patch), _is_ controlled by
> --quiet.

Ah, sorry, this has actually changed since the last time I looked at it closely, as a result of 9c4a036 (Teach the --all option to 'git fetch', 2009-11-09). So nevermind my complaint...it has actually been addressed separately (I didn't notice because I have been suppressing the output by redirecting stdout for some time).

> Thus I feel like "Updating %s" should change to "Fetching %s" for both
> consistency and explicitness, and should also be controlled by
> --quiet.  The --quiet-remote option is an entirely different bikeshed,
> which I don't have a strong opinion on, offhand.

Yes, I agree (that it should be quieted, and that it should say "Fetching"). My --quiet-remote argument is now pointless as of 9c4a036b.

-Peff