Re: [PATCH] Allow --quiet option to git remote, particularly for `git remote update`
- From
Jeff King <peff@peff.net>
- Date
- Dec 6, 2009, 14:50 UTC
- Message-ID
- <20091206145000.GC26440@coredump.intra.peff.net>
- In-Reply-To
- <1260057623-28960-1-git-send-email-alex@chmrr.net>
On Sat, Dec 05, 2009 at 07:00:23PM -0500, Alex Vandiver wrote:
Show 13 quoted lines
> @@ -84,9 +84,12 @@ static int opt_parse_track(const struct option *opt, const char *arg, int not)
> static int fetch_remote(const char *name)
> {
> const char *argv[] = { "fetch", name, NULL, NULL };
> - if (verbose) {
> + if (verbosity > 0) {
> argv[1] = "-v";
> argv[2] = name;
> + } else if (verbosity < 0) {
> + argv[1] = "-q";
> + argv[2] = name;
> }
> printf("Updating %s\n", name);Should --quiet also affect this "Updating %s" line?
Actually, I have often wished for a way to shut up this line but keep fetch at its normal verbosity. Fetch very sanely says nothing if there is nothing to update, but you still get this "Updating" junk line, even if nothing is transferred. But that would probably need an extra "--quiet-remote" option to handle separately from what we pass to fetch.
-Peff