Re: [PATCH] fix git-parse-remote.sh for remotes that contain slashes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 14, 2011, 19:55 UTC
- Message-ID
- <7vd3nzntuf.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1295005000-11562-1-git-send-email-stefan.naewe@gmail.com>
Stefan Naewe <stefan.naewe@gmail.com> writes:
> Signed-off-by: Stefan Naewe <stefan.naewe@gmail.com> > ---
Thanks, but no explanation?
Imagine somebody who weren't reading this thread (especially the article you responded to with this patch) sees this in "git log" output stream. For that matter, imagine yourself doing that in 2012 when the motivation of this change you all forgot already.
Do you think it is obvious what the problem the patch tried to fix was? I don't. "fix" on the subject line gives you 0-bit information for that purpose.
Show 16 quoted lines
> diff --git a/git-parse-remote.sh b/git-parse-remote.sh
> index 5f47b18..7cf204e 100644
> --- a/git-parse-remote.sh
> +++ b/git-parse-remote.sh
> @@ -7,8 +7,12 @@ GIT_DIR=$(git rev-parse -q --git-dir) || :;
> get_data_source () {
> case "$1" in
> */*)
> - echo ''
> - ;;
> + if test "$(git config --get "remote.$1.url")"
> + then
> + echo config
> + else
> + echo ''
> + fi ;;I suspect that making this case arm trigger not on */* but only on /* and ../* would be a lot more sensible solution. Otherwise you would still have the same issue in repositories that use remotes/ and branches/ mechanism.
git-parse-remote.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-parse-remote.sh b/git-parse-remote.sh index 1cc2ba6..8ec33e3 100644 --- a/git-parse-remote.sh +++ b/git-parse-remote.sh @@ -6,7 +6,7 @@ GIT_DIR=$(git rev-parse -q --git-dir) || :; get_data_source () { case "$1" in - */*) + ../* | /*) echo '' ;; .)