git/list[1] front-page[2] threads[3] people[4] search[5] about
 

bug: request-pull broken when remote name contains a slash

From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date
Jan 14, 2011, 09:06 UTC
Message-ID
<20110114090645.GA13060@pengutronix.de>
Hello,
the remotes in my linux repo look as follows:
	[remote "ptx/ukl"]
		url = git://git.pengutronix.de/git/ukl/linux-2.6.git
		push = +refs/heads/*:refs/heads/*
		fetch = +refs/heads/*:refs/remotes/ptx/ukl/*
	[remote "ptx/otheruser"]
		url = git://git.pengutronix.de/git/otheruser/linux-2.6.git
		fetch = +refs/heads/*:refs/remotes/ptx/otheruser/*
	[remote "ptx/yetanotheruser"]
		url = git://git.pengutronix.de/git/yetanotheruser/linux-2.6.git
		fetch = +refs/heads/*:refs/remotes/ptx/yetanotheruser/*
unfortunately this makes sending request pulls uncomfortable:
	ukl@octopus:~/gsrc/linux-2.6$ git request-pull HEAD^ ptx/ukl
	The following changes since commit a08948812b30653eb2c536ae613b635a989feb6f:
	  Merge branch 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging (2011-01-10 08:57:46 -0800)
	are available in the git repository at:
	  ptx/ukl mxs/for-2.6.38
	...

The reason for that is in git-parse-remote.sh:get_data_source() which assumes that a remote with a slash is a filename and so get_remote_url doesn't use $(git config --get "remote.$1.url") but ptx/ukl directly.

Best regards Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Next: Stefan Naewe
Message 1 of 8 in “bug: request-pull broken when remote name contains a slash”
  1. Uwe Kleine-KönigJan 14, 2011
  2. fix git-parse-remote.sh for remotes that contain slashesStefan Naewe, Jan 14, 2011
  3. Junio C HamanoJan 14, 2011
  4. get_remote_url(): use the same data source as ls-remote to get remote urlsUwe Kleine-König, Feb 28, 2011
  5. Junio C HamanoFeb 28, 2011
  6. Uwe Kleine-KönigMar 1, 2011
  7. 1/2 get_remote_url(): use the same data source as ls-remote to get remote urlsUwe Kleine-König, Mar 1, 2011
  8. 2/2 git-request-pull: open-code the only invocation of get_remote_urlUwe Kleine-König, Mar 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.