bug: request-pull broken when remote name contains a slash
- From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
- Date
- Jan 14, 2011, 09:06 UTC
- Message-ID
- <20110114090645.GA13060@pengutronix.de>
Hello,
the remotes in my linux repo look as follows:
[remote "ptx/ukl"] url = git://git.pengutronix.de/git/ukl/linux-2.6.git push = +refs/heads/*:refs/heads/* fetch = +refs/heads/*:refs/remotes/ptx/ukl/*
[remote "ptx/otheruser"] url = git://git.pengutronix.de/git/otheruser/linux-2.6.git fetch = +refs/heads/*:refs/remotes/ptx/otheruser/*
[remote "ptx/yetanotheruser"] url = git://git.pengutronix.de/git/yetanotheruser/linux-2.6.git fetch = +refs/heads/*:refs/remotes/ptx/yetanotheruser/*
unfortunately this makes sending request pulls uncomfortable:
ukl@octopus:~/gsrc/linux-2.6$ git request-pull HEAD^ ptx/ukl The following changes since commit a08948812b30653eb2c536ae613b635a989feb6f:
Merge branch 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging (2011-01-10 08:57:46 -0800)
are available in the git repository at:
ptx/ukl mxs/for-2.6.38 ...
The reason for that is in git-parse-remote.sh:get_data_source() which assumes that a remote with a slash is a filename and so get_remote_url doesn't use $(git config --get "remote.$1.url") but ptx/ukl directly.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |