git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] git-request-pull: open-code the only invocation of get_remote_url

From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date
Mar 1, 2011, 09:21 UTC
Message-ID
<1298971297-20326-2-git-send-email-u.kleine-koenig@pengutronix.de>
In-Reply-To
<20110301084110.GT22310@pengutronix.de>

So sh:get_remote_url can go now and git-request-pull doesn't need to source git-parse-remote. anymore.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 git-parse-remote.sh |    4 ----
 git-request-pull.sh |    3 +--
 2 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/git-parse-remote.sh b/git-parse-remote.sh
index 0ab1192..e7013f7 100644
--- a/git-parse-remote.sh
+++ b/git-parse-remote.sh
@@ -4,10 +4,6 @@
 # this would fail in that case and would issue an error message.
 GIT_DIR=$(git rev-parse -q --git-dir) || :;
 
-get_remote_url () {
-	git ls-remote --get-url "$1"
-}
-
 get_default_remote () {
 	curr_branch=$(git symbolic-ref -q HEAD | sed -e 's|^refs/heads/||')
 	origin=$(git config --get "branch.$curr_branch.remote")
diff --git a/git-request-pull.sh b/git-request-pull.sh
index 6fdea39..fc080cc 100755
--- a/git-request-pull.sh
+++ b/git-request-pull.sh
@@ -15,7 +15,6 @@ p    show patch text as well
 '
 
 . git-sh-setup
-. git-parse-remote
 
 GIT_PAGER=
 export GIT_PAGER
@@ -55,7 +54,7 @@ branch=$(git ls-remote "$url" \
 		p
 		q
 	}")
-url=$(get_remote_url "$url")
+url=$(git ls-remote --get-url "$url")
 if [ -z "$branch" ]; then
 	echo "warn: No branch of $url is at:" >&2
 	git log --max-count=1 --pretty='tformat:warn:   %h: %s' $headrev >&2
-- 
1.7.2.3
Previous: Uwe Kleine-König
Message 8 of 8 in “bug: request-pull broken when remote name contains a slash”
  1. Uwe Kleine-KönigJan 14, 2011
  2. fix git-parse-remote.sh for remotes that contain slashesStefan Naewe, Jan 14, 2011
  3. Junio C HamanoJan 14, 2011
  4. get_remote_url(): use the same data source as ls-remote to get remote urlsUwe Kleine-König, Feb 28, 2011
  5. Junio C HamanoFeb 28, 2011
  6. Uwe Kleine-KönigMar 1, 2011
  7. 1/2 get_remote_url(): use the same data source as ls-remote to get remote urlsUwe Kleine-König, Mar 1, 2011
  8. 2/2 git-request-pull: open-code the only invocation of get_remote_urlUwe Kleine-König, Mar 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.