git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: respect --no-ext-diff with typechange

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 18, 2012, 22:47 UTC
Message-ID
<7vd33swuti.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120718070626.GA20938@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I don't care too deeply either way, and it is technically a behavior
> change. So there is a chance of regression for something that nobody has
> actually complained about.

Thanks. I share the same feeling, but the code after the patch looks much nicer, which is somewhat sad.

> To be honest, I doubt many people are using
> external diff at all these days; textconv is closer to what most people
> want, and is much easier to use.

It depends on the payload and the output you want. I wouldn't think it is fair to challenge anybody to come up with a solution based on the textconv machinery to replicate what the compare-cooking.perl in the 'todo' branch (used as an external diff driver for whats-cooking.txt) does.

Previous: Jeff KingNext: Jeff King
Message 7 of 8 in “diff: respect --no-ext-diff with typechange”
  1. diff: respect --no-ext-diff with typechangeJakub Vrana, Jul 17, 2012
  2. Jeff KingJul 17, 2012
  3. Jakub VranaJul 18, 2012
  4. Junio C HamanoJul 18, 2012
  5. Jeff KingJul 18, 2012
  6. Jeff KingJul 18, 2012
  7. Junio C HamanoJul 18, 2012
  8. Jeff KingJul 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.