From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 18 Jul 2012 22:47:21 GMT
Subject: Re: [PATCH] diff: respect --no-ext-diff with typechange
Message-ID: <7vd33swuti.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120718070626.GA20938@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I don't care too deeply either way, and it is technically a behavior
> change. So there is a chance of regression for something that nobody has
> actually complained about.

Thanks. I share the same feeling, but the code after the patch looks
much nicer, which is somewhat sad.

> To be honest, I doubt many people are using
> external diff at all these days; textconv is closer to what most people
> want, and is much easier to use.

It depends on the payload and the output you want.  I wouldn't think
it is fair to challenge anybody to come up with a solution based on
the textconv machinery to replicate what the compare-cooking.perl in
the 'todo' branch (used as an external diff driver for
whats-cooking.txt) does.