git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] diff: respect --no-ext-diff with typechange

From
JVJakub Vrana <jakub@vrana.cz>
Date
Jul 17, 2012, 00:27 UTC
Message-ID
<000301cd63b2$e39a2130$aace6390$@vrana.cz>

If external diff is specified through diff.external then it is used even if `git diff --no-ext-diff` is used when there is a typechange.

Signed-off-by: Jakub Vrana <jakub@vrana.cz>
---
 diff.c |    3 +++
 1 file changed, 3 insertions(+)
diff --git a/diff.c b/diff.c
index 208096f..898d610 100644
--- a/diff.c
+++ b/diff.c
@@ -3074,6 +3074,9 @@ static void run_diff(struct diff_filepair *p, struct
diff_options *o)
 	if (o->prefix_length)
 		strip_prefix(o->prefix_length, &name, &other);
 
+	if (!DIFF_OPT_TST(o, ALLOW_EXTERNAL))
+		pgm = NULL;
+
 	if (DIFF_PAIR_UNMERGED(p)) {
 		run_diff_cmd(pgm, name, NULL, attr_path,
 			     NULL, NULL, NULL, o, p);
-- 
1.7.10.msysgit.1
Next: Jeff King
Message 1 of 8 in “diff: respect --no-ext-diff with typechange”
  1. diff: respect --no-ext-diff with typechangeJakub Vrana, Jul 17, 2012
  2. Jeff KingJul 17, 2012
  3. Jakub VranaJul 18, 2012
  4. Junio C HamanoJul 18, 2012
  5. Jeff KingJul 18, 2012
  6. Jeff KingJul 18, 2012
  7. Junio C HamanoJul 18, 2012
  8. Jeff KingJul 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.