Re: Git.pm with recent File::Temp fail
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 29, 2013, 08:18 UTC
- Message-ID
- <7vd2tdn41h.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vy5c1narj.fsf@alter.siamese.dyndns.org>
Here is what I'll queue.
Thanks for the help, all of you.
-- >8 -- From: H. Merijn Brand <h.m.brand@xs4all.nl> Subject: Git.pm: call tempfile from File::Temp as a regular function
We call File::Temp's "tempfile" function as a class method, but it was never designed to be called this way. Older versions seemed to tolerate it, but as of File::Temp 0.23, it blows up like this:
$ git svn fetch 'tempfile' can't be called as a method at .../Git.pm line 1117.
Fix it by calling it as a regular function, just inside the File::Temp namespace.
Signed-off-by: H. Merijn Brand <h.m.brand@xs4all.nl> Helped-by: Jeff King <peff@peff.net> --- perl/Git.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/perl/Git.pm b/perl/Git.pm index 497f420..76383b9 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -1039,7 +1039,7 @@ sub _temp_cache { $tmpdir = $self->repo_path(); } - ($$temp_fd, $fname) = File::Temp->tempfile( + ($$temp_fd, $fname) = File::Temp::tempfile( 'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir, ) or throw Error::Simple("couldn't open new temp file");