Git.pm with recent File::Temp fail
- From
H.Merijn Brand <h.m.brand@xs4all.nl>
- Date
- Mar 22, 2013, 19:57 UTC
- Message-ID
- <20130322205758.09ca9107@pc09.procura.nl>
git-1.8.2, perl-5.16.3, File::Temp-0.23
Without patch:
$ git svn fetch 'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117.
After patch:
$ git svn fetch
M t/06virtual.t
r15506 = 6c65be7ff36ffc6fd9b960a4b470ca297103004e (refs/remotes/git-svn)
⋮patch attached
--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
>From e78bf3e99deb26050f8515076db63075f6d0d171 Mon Sep 17 00:00:00 2001
From: "H.Merijn Brand - Tux" <h.m.brand@xs4all.nl>
Date: Fri, 22 Mar 2013 20:56:53 +0100
Subject: [PATCH] Syntax error in Git.pm for File::Temp-0.23
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------1.8.2"
This is a multi-part message in MIME format.
--------------1.8.2
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit
Testing with perl-5.16.3 and most recent File::Temp-0.23 revealed:
$ git svn fetch
'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117.
---
perl/Git.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--------------1.8.2
Content-Type: text/x-patch; name="0001-Syntax-error-in-Git.pm-for-File-Temp-0.23.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Syntax-error-in-Git.pm-for-File-Temp-0.23.patch"
diff --git a/perl/Git.pm b/perl/Git.pm
index 96cac39..cf4f54a 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -1265,7 +1265,7 @@ sub _temp_cache {
$tmpdir = $self->repo_path();
}
- ($$temp_fd, $fname) = File::Temp->tempfile(
+ ($$temp_fd, $fname) = File::Temp::tempfile(
'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,
) or throw Error::Simple("couldn't open new temp file");
--------------1.8.2--