Re: [PATCH v2 0/2] remote-bzr: couple of fixes

From: Junio C Hamano <gitster@pobox.com>
Date: May 5, 2013, 18:33 UTC
Message-ID: <7vd2t5uvi2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1367627467-15132-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> The previous version had an indentation bug (did I mention I hate python?).
>
> A few fixes to be applied on top of the massive changes already queued. Nothing
> major.

[2/2] may not matter much in the context of my tree (people would use post 1.8.2 fast-export if they are using remote-bzr from 1.8.3 from my tree ;-), but [1/2] sounds like it is a good thing to have in 1.8.3 (not "on top of that 'massive' series").

Assuming the "otherwise some version of bzr might barf" problem is that repo.generate_revision_history() in those versions may not apply str() to its first parameter and the caller is expected to pass a string there, or something?

Thanks.

Show 7 quoted lines

>
> Felipe Contreras (2):
>   remote-bzr: convert all unicode keys to str
>   remote-bzr: avoid bad refs
>
>  contrib/remote-helpers/git-remote-bzr | 42 +++++++++++++++++++++--------------
>  1 file changed, 25 insertions(+), 17 deletions(-)