git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] remote-bzr: convert all unicode keys to str

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 4, 2013, 00:31 UTC
Message-ID
<1367627467-15132-2-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1367627467-15132-1-git-send-email-felipe.contreras@gmail.com>
Otherwise some versions of bazaar might barf.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/git-remote-bzr | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index 161f831..bbaaa8f 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -95,7 +95,7 @@ class Marks:
         return self.marks[rev]
 
     def to_rev(self, mark):
-        return self.rev_marks[mark]
+        return str(self.rev_marks[mark])
 
     def next_mark(self):
         self.last_mark += 1
@@ -621,7 +621,7 @@ def parse_commit(parser):
         files[path] = f
 
     committer, date, tz = committer
-    parents = [str(mark_to_rev(p)) for p in parents]
+    parents = [mark_to_rev(p) for p in parents]
     revid = bzrlib.generate_ids.gen_revision_id(committer, date)
     props = {}
     props['branch-nick'] = branch.nick
-- 
1.8.3.rc0.401.g45bba44
Previous: Felipe ContrerasNext: Felipe Contreras
Message 2 of 10 in “remote-bzr: couple of fixes”
  1. 0/2 remote-bzr: couple of fixesFelipe Contreras, May 4, 2013
  2. 1/2 remote-bzr: convert all unicode keys to strFelipe Contreras, May 4, 2013
  3. 2/2 remote-bzr: avoid bad refsFelipe Contreras, May 4, 2013
  4. Stefano LattariniMay 4, 2013
  5. Junio C HamanoMay 5, 2013
  6. Felipe ContrerasMay 5, 2013
  7. Junio C HamanoMay 5, 2013
  8. Felipe ContrerasMay 5, 2013
  9. Junio C HamanoMay 5, 2013
  10. Felipe ContrerasMay 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.