git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusing

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 29, 2008, 09:57 UTC
Message-ID
<7vbpuvcnhh.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20081229095220.GA26942@chistera.yi.org>
Adeodato Simó <dato@net.com.org.es> writes:
Show 12 quoted lines
> * Junio C Hamano [Mon, 29 Dec 2008 01:46:02 -0800]:
> ...
>> That 'zort' came from 1320857 (builtin-commit: fix --signoff, 2007-11-11),
>> and I _think_ it is trying to make sure that presense of "-F -" makes the
>> editor not to trigger.
>
> Hm. Well, if that is true, then IMHO it should be in a /separate/ test
> case, for clarity. Probably in "message from stdin" test from t7501.
>
> That's of course just my opinion, and I'll accept if you prefer to
> maintain it the way it is now. I also volunteer to move it to t7501 if
> that's what you prefer, just let me know.
I underscored _think_ and CC'ed Dscho for a reason.

If "-F -" has a bug, and if you do not define GIT_EDITOR, your test may not work unattended (i.e. neither succeed nor finish but gets stuck). Perhaps that is the issue? I dunno.

Previous: Adeodato SimóNext: Johannes Schindelin
Message 4 of 9 in “t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusing”
  1. t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusingAdeodato Simó, Dec 29, 2008
  2. Junio C HamanoDec 29, 2008
  3. Adeodato SimóDec 29, 2008
  4. Junio C HamanoDec 29, 2008
  5. Johannes SchindelinDec 30, 2008
  6. t7501-commit.sh: explicitly check that -F prevents invoking the editorAdeodato Simó, Jan 9, 2009
  7. Johannes SchindelinJan 10, 2009
  8. Adeodato SimóJan 10, 2009
  9. Johannes SchindelinJan 10, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.