From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 29 Dec 2008 09:57:46 GMT
Subject: Re: [PATCH] t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusing
Message-ID: <7vbpuvcnhh.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081229095220.GA26942@chistera.yi.org>

Adeodato Simó <dato@net.com.org.es> writes:

> * Junio C Hamano [Mon, 29 Dec 2008 01:46:02 -0800]:
> ...
>> That 'zort' came from 1320857 (builtin-commit: fix --signoff, 2007-11-11),
>> and I _think_ it is trying to make sure that presense of "-F -" makes the
>> editor not to trigger.
>
> Hm. Well, if that is true, then IMHO it should be in a /separate/ test
> case, for clarity. Probably in "message from stdin" test from t7501.
>
> That's of course just my opinion, and I'll accept if you prefer to
> maintain it the way it is now. I also volunteer to move it to t7501 if
> that's what you prefer, just let me know.

I underscored _think_ and CC'ed Dscho for a reason.

If "-F -" has a bug, and if you do not define GIT_EDITOR, your test may
not work unattended (i.e. neither succeed nor finish but gets stuck).
Perhaps that is the issue?  I dunno.