Re: [PATCH] t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusing

From: Adeodato Simó <dato@net.com.org.es>
Date: Dec 29, 2008, 09:52 UTC
Message-ID: <20081229095220.GA26942@chistera.yi.org>
In-Reply-To: <7vmyefco11.fsf@gitster.siamese.dyndns.org>

* Junio C Hamano [Mon, 29 Dec 2008 01:46:02 -0800]:

> Adeodato Simó <dato@net.com.org.es> writes:

> > I was reading this test case, and it took a small bit to figure out the
> > editor was not being used at all. I hope there was no hidden reason for
> > it to be there, and it can go away.

> That 'zort' came from 1320857 (builtin-commit: fix --signoff, 2007-11-11),
> and I _think_ it is trying to make sure that presense of "-F -" makes the
> editor not to trigger.

Hm. Well, if that is true, then IMHO it should be in a /separate/ test case, for clarity. Probably in "message from stdin" test from t7501.

That's of course just my opinion, and I'll accept if you prefer to maintain it the way it is now. I also volunteer to move it to t7501 if that's what you prefer, just let me know.

Thanks,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
                              Listening to: Justin Nozuka - I'm In Peace