Re: Please pull gitk.git master branch

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 13, 2010, 07:40 UTC
Message-ID: <7vbp4q5ddo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v7hfe74ea.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> My _preferred_ outcome is to see that naming the input "po/pt_br.po" and
> using the output "po/pt_br.msg" is the BCP, but I'd like somebody to find
> out what the accepted practice would be in the Tcl land first.

I still don't know what the BCP is in the Tcl community (didn't have time to check, dealing with other topics), but I'll tentatively apply this on top of queue Alexandre's patch and merge the result in 'pu'.

-- >8 --
From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 12 Dec 2010 23:27:21 -0800
Subject: [PATCH] Rename po/pt_BR.po to po/pt_br.po

The "msgfmt --tcl pt_BR.po" (at least on my box, GNU gettext 0.17) command generates pt_BR.msg, i.e. the country part gets downcased. The resulting runtime (i.e. Tcl i18n) happily reads from pt_br.msg when run with the runtime locale set with LANG=pt_BR and/or LC_ALL=pt_BR so it seems to be the expected behaviour.

However, we seem to expect that the resulting file to be named pt_BR.msg, and try to generate and install it.

Currently our Makefile uses $(wildcard po/*.po) to grab the source PO files, expects them to produce $(subst .po,.msg,$(ALL_POFILES)), and its dependency rule is set to use "%.msg : %.po" pattern, all of which need to be adjusted with downcasing from po to msg files; the poor-man's msgfmt script also needs to learn the same downcasing.

Compared to that, renaming the input file to use lowercase countryname throughout the toolchain seems to be a lot cleaner solution to this glitch.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 po/{pt_BR.po => pt_br.po} |    0
 1 files changed, 0 insertions(+), 0 deletions(-)
 rename po/{pt_BR.po => pt_br.po} (100%)

diff --git a/po/pt_BR.po b/po/pt_br.po
similarity index 100%
rename from po/pt_BR.po
rename to po/pt_br.po