git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] clone: allow to clone from .git file

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 22, 2011, 19:02 UTC
Message-ID
<7vbovhw9pb.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CACsJy8BaCwT+fd-KORsqXqQEtWZUpTDwgoSGU9+pMfNdero5=Q@mail.gmail.com>
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
Show 7 quoted lines
>> Didn't somebody add "is this '.git' thing a valid git metadirectory?" API
>> quite recently for exactly this?
>>
>
> You mean resolve_gitdir() in abc0682 (rev-parse: add option
> --resolve-git-dir <path> - 2011-08-15)? That function would barf on a
> bundle file.

Well, then it has to be fixed, perhaps to return NULL instead as other failure cases, as read_gitfile_GENTLY() should be gentle to the callers so that they can notice error cases and deal with them themselves.

Previous: Nguyen Thai Ngoc DuyNext: Junio C Hamano
Message 5 of 9 in “clone: allow to clone from .git file”
  1. 1/2 clone: allow to clone from .git fileNguyễn Thái Ngọc Duy, Aug 21, 2011
  2. 2/2 Do not accept NUL in the path in .git fileNguyễn Thái Ngọc Duy, Aug 21, 2011
  3. Junio C HamanoAug 21, 2011
  4. Nguyen Thai Ngoc DuyAug 22, 2011
  5. Junio C HamanoAug 22, 2011
  6. Re* [PATCH 1/2] clone: allow to clone from .git fileJunio C Hamano, Aug 22, 2011
  7. Nguyen Thai Ngoc DuyAug 23, 2011
  8. Junio C HamanoAug 23, 2011
  9. Nguyen Thai Ngoc DuyAug 23, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.