From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 22 Aug 2011 19:02:56 GMT
Subject: Re: [PATCH 1/2] clone: allow to clone from .git file
Message-ID: <7vbovhw9pb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8BaCwT+fd-KORsqXqQEtWZUpTDwgoSGU9+pMfNdero5=Q@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

>> Didn't somebody add "is this '.git' thing a valid git metadirectory?" API
>> quite recently for exactly this?
>>
>
> You mean resolve_gitdir() in abc0682 (rev-parse: add option
> --resolve-git-dir <path> - 2011-08-15)? That function would barf on a
> bundle file.

Well, then it has to be fixed, perhaps to return NULL instead as other
failure cases, as read_gitfile_GENTLY() should be gentle to the callers so
that they can notice error cases and deal with them themselves.