Re: [PATCH 1/2] clone: allow to clone from .git file
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Aug 22, 2011, 03:08 UTC
- Message-ID
- <CACsJy8BaCwT+fd-KORsqXqQEtWZUpTDwgoSGU9+pMfNdero5=Q@mail.gmail.com>
- In-Reply-To
- <7v7h66y4s5.fsf@alter.siamese.dyndns.org>
2011/8/22 Junio C Hamano <gitster@pobox.com>:
Show 10 quoted lines
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> + else if (S_ISREG(st.st_mode) && st.st_size > 8) {
>> + /* Despite the name read_gitfile_gently can be
>> + cruel on non .git file, check for signature
>> + ourselves */
>
> Didn't somebody add "is this '.git' thing a valid git metadirectory?" API
> quite recently for exactly this?
>You mean resolve_gitdir() in abc0682 (rev-parse: add option --resolve-git-dir <path> - 2011-08-15)? That function would barf on a bundle file. I'm not aware of any other functions.
-- Duy