Re: [PATCH 0/4] jk/version-string and google code
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 10, 2012, 21:42 UTC
- Message-ID
- <7vboiiifu4.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120810213508.GC888@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> Yes, I think that is all that is necessary to fix the immediate issue.
> The protocol-capabilities document talks about what to do when
> include-tag is not available ("SHOULD issue a subsequent fetch to
> acquire the tags that include-tag would have otherwise given the
> client"), but I am not sure how well we handle that (in theory we should
> be handling it already, but I didn't look).Yeah, it is more like "A separate fetch only to follow tags was the only way we handled it before we added include-tag, so we know it used to work, and also we know the four combinations of new/old * fetch/upload all used to work".
We may have broken some combinations over time, though.