git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] jk/version-string and google code

From
Jeff King <peff@peff.net>
Date
Aug 10, 2012, 17:46 UTC
Message-ID
<20120810174605.GA29113@sigill.intra.peff.net>
In-Reply-To
<7vfw7ulq0a.fsf@alter.siamese.dyndns.org>
On Fri, Aug 10, 2012 at 08:34:45AM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Ugh, the jk/version-string topic breaks fetching from Google Code. With
> > my patch, the client unconditionally sends an "agent=foo" capability,
> > but the server does not like seeing the unknown capability and ends the
> > connection (I'm guessing with some kind of internal exception, since it
> > spews "Internal server error" over the protocol channel).
> 
> The fix looks sane and the right thing to do.
> 
> I've been using 'next' and started seeing this breakage when pushing
> to code.google.com only a few days ago.  My reflog tells that
> ff5effd (include agent identifier in capability string, 2012-08-03)
> was merged to my everyday-work branch on this Monday, which is more
> or less consistent with what I am observing.

Thanks for confirming the push side. I have been running with the patch for months, but only recently happened to try cloning something from code.google.com. I assumed the push side had the same problem, but did not want to make a new project just to test (and it seemed fairly obvious that it would have the same issue).

It was pure coincidence that it happened at the same time you were graduating the topic to next. But I'm glad I was able to catch it before anybody started complaining. :)

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 24 of 37 in “jk/version-string and google code”
  1. 0/4 jk/version-string and google codeJeff King, Aug 10, 2012
  2. 1/4 send-pack: fix capability-sending logicJeff King, Aug 10, 2012
  3. 2/4 do not send client agent unless server does firstJeff King, Aug 10, 2012
  4. Junio C HamanoAug 10, 2012
  5. Jeff KingAug 10, 2012
  6. 3/4 connect: learn to parse capabilities with valuesJeff King, Aug 10, 2012
  7. Eric SunshineAug 10, 2012
  8. Junio C HamanoAug 10, 2012
  9. Jeff KingAug 10, 2012
  10. Junio C HamanoAug 10, 2012
  11. Junio C HamanoAug 13, 2012
  12. 4/4 fetch-pack: mention server version with verbose outputJunio C Hamano, Aug 13, 2012
  13. Junio C HamanoAug 13, 2012
  14. Jeff KingAug 13, 2012
  15. Junio C HamanoAug 13, 2012
  16. Jeff KingAug 13, 2012
  17. Junio C HamanoAug 13, 2012
  18. Jeff KingAug 13, 2012
  19. Jeff KingAug 14, 2012
  20. Jeff KingAug 14, 2012
  21. Junio C HamanoAug 14, 2012
  22. 4/4 fetch-pack: mention server version with verbose outputJeff King, Aug 10, 2012
  23. Junio C HamanoAug 10, 2012
  24. Jeff KingAug 10, 2012
  25. Junio C HamanoAug 10, 2012
  26. Jeff KingAug 10, 2012
  27. Shawn PearceAug 10, 2012
  28. Junio C HamanoAug 10, 2012
  29. Junio C HamanoAug 10, 2012
  30. Dave BorowitzAug 10, 2012
  31. Jeff KingAug 10, 2012
  32. Dave BorowitzAug 10, 2012
  33. Jeff KingAug 10, 2012
  34. Junio C HamanoAug 10, 2012
  35. Jeff KingAug 10, 2012
  36. Junio C HamanoAug 10, 2012
  37. Junio C HamanoAug 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.