git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] fetch-pack: mention server version with verbose output

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 13, 2012, 19:07 UTC
Message-ID
<7v7gt2ehl4.fsf_-_@alter.siamese.dyndns.org>
In-Reply-To
<7vboieehrf.fsf@alter.siamese.dyndns.org>

Fetch-pack's verbose mode is more of a debugging mode (and in fact takes two "-v" arguments to trigger via the porcelain layer). Let's mention the server version as another possible item of interest.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 * And this is your 4 adjusted for the previous one, releaving the
   caller from having to figure out where the capability string
   ends.
 builtin/fetch-pack.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c
index fdec7f6..1633aa3 100644
--- a/builtin/fetch-pack.c
+++ b/builtin/fetch-pack.c
@@ -787,6 +787,8 @@ static struct ref *do_fetch_pack(int fd[2],
 {
 	struct ref *ref = copy_ref_list(orig_ref);
 	unsigned char sha1[20];
+	const char *agent_feature = NULL;
+	int agent_len;
 
 	sort_ref_list(&ref, ref_compare_name);
 
@@ -829,8 +831,15 @@ static struct ref *do_fetch_pack(int fd[2],
 			fprintf(stderr, "Server supports ofs-delta\n");
 	} else
 		prefer_ofs_delta = 0;
-	if (server_supports("agent"))
+
+	if ((agent_feature = server_feature("agent", &agent_len)) != NULL &&
+	    5 < agent_len && agent_feature[5] == '=') {
 		agent_supported = 1;
+		if (args.verbose) {
+			fprintf(stderr, "Server version is %.*s\n",
+				agent_len - 6, agent_feature + 6);
+		}
+	}
 
 	if (everything_local(&ref, nr_match, match)) {
 		packet_flush(fd[1]);
-- 
1.7.12.rc2.85.g1de7134
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 37 in “jk/version-string and google code”
  1. 0/4 jk/version-string and google codeJeff King, Aug 10, 2012
  2. 1/4 send-pack: fix capability-sending logicJeff King, Aug 10, 2012
  3. 2/4 do not send client agent unless server does firstJeff King, Aug 10, 2012
  4. Junio C HamanoAug 10, 2012
  5. Jeff KingAug 10, 2012
  6. 3/4 connect: learn to parse capabilities with valuesJeff King, Aug 10, 2012
  7. Eric SunshineAug 10, 2012
  8. Junio C HamanoAug 10, 2012
  9. Jeff KingAug 10, 2012
  10. Junio C HamanoAug 10, 2012
  11. Junio C HamanoAug 13, 2012
  12. 4/4 fetch-pack: mention server version with verbose outputJunio C Hamano, Aug 13, 2012
  13. Junio C HamanoAug 13, 2012
  14. Jeff KingAug 13, 2012
  15. Junio C HamanoAug 13, 2012
  16. Jeff KingAug 13, 2012
  17. Junio C HamanoAug 13, 2012
  18. Jeff KingAug 13, 2012
  19. Jeff KingAug 14, 2012
  20. Jeff KingAug 14, 2012
  21. Junio C HamanoAug 14, 2012
  22. 4/4 fetch-pack: mention server version with verbose outputJeff King, Aug 10, 2012
  23. Junio C HamanoAug 10, 2012
  24. Jeff KingAug 10, 2012
  25. Junio C HamanoAug 10, 2012
  26. Jeff KingAug 10, 2012
  27. Shawn PearceAug 10, 2012
  28. Junio C HamanoAug 10, 2012
  29. Junio C HamanoAug 10, 2012
  30. Dave BorowitzAug 10, 2012
  31. Jeff KingAug 10, 2012
  32. Dave BorowitzAug 10, 2012
  33. Jeff KingAug 10, 2012
  34. Junio C HamanoAug 10, 2012
  35. Jeff KingAug 10, 2012
  36. Junio C HamanoAug 10, 2012
  37. Junio C HamanoAug 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.